Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile fixes #1686

Merged
merged 17 commits into from
Aug 29, 2020
Merged

Mobile fixes #1686

merged 17 commits into from
Aug 29, 2020

Conversation

goto-bus-stop
Copy link
Member

@goto-bus-stop goto-bus-stop commented Aug 28, 2020

  • Syncs the mobile components with "recent" material-ui updates (from the past 2 years or so....)

  • Fixes issues with overlays not being closable

  • Makes the settings panel more responsive, and especially puts the useful things at the top for mobile users as well as desktop users

    Screenshots

    Desktop

    image

    Mobile

    image

Still todo:

  • Fix the headers for the playlist view
  • Alignment in the server listing
  • Also vertical alignment in the app bar …
  • Use the current videoDisabled style also when nobody is playing (but with different text)
  • Hide the Playlists drawer menu header if not signed in
  • The vote icons in the room history don't fit in the slightest…work out a different approach
  • The mobile loading screen does not show errors
  • The mobile loading screen has icons that look clickable, maybe hide them

@goto-bus-stop goto-bus-stop marked this pull request as ready for review August 29, 2020 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant